From: Derrick Stolee <stolee@gmail.com>
Date: Mon, 03 May 2021 16:30:04 GMT
Subject: Re: [PATCH 2/6] fetch-pack: refactor process_acks()
Message-ID: <15b4fb49-6254-bd6f-4c34-f04b55adced8@gmail.com>
In-Reply-To: <6a9f78df1a3513df04ac3275cd1feccfb6cf87b1.1617929278.git.jonathantanmy@google.com>

On 4/8/21 9:09 PM, Jonathan Tan wrote:
> A subsequent commit will need part, but not all, of the functionality in
> process_acks(), so move some of its functionality to its sole caller
> do_fetch_pack_v2(). As a side effect, the resulting code is also
> shorter.
>  		case FETCH_PROCESS_ACKS:
>  			/* Process ACKs/NAKs */
> -			switch (process_acks(negotiator, &reader, &common)) {

Good riddance to this nested switch!

I am unfamiliar with this code, but I believe these changes to
be correct.

Thanks,
-Stolee