From: David Turner <novalis@novalis.org>
Date: Thu, 08 Feb 2018 01:02:31 GMT
Subject: Re: [PATCH v1] name-hash: properly fold directory names in adjust_dirname_case()
Message-ID: <1518051751.15704.476.camel@novalis.org>
In-Reply-To: <20180208004156.36224-1-benpeart@microsoft.com>

On Wed, 2018-02-07 at 19:41 -0500, Ben Peart wrote:
> Correct the pointer arithmetic in adjust_dirname_case() so that it
> calls
> find_dir_entry() with the correct string length.  Previously passing
> in
> "dir1/foo" would pass a length of 6 instead of the correct 4.  This
> resulted in
> find_dir_entry() never finding the entry and so the subsequent memcpy
> that would
> fold the name to the version with the correct case never executed.
> 
> Add a test to validate the corrected behavior with name folding of
> directories.

Looks good to me.