From: Kaartic Sivaraam Date: Tue, 04 Jul 2017 20:03:27 GMT Subject: Re: Why doesn't merge fail if message has only sign-off? Message-ID: <1499198607.6428.9.camel@gmail.com> In-Reply-To: On Mon, 2017-07-03 at 10:21 -0700, Junio C Hamano wrote: > I think that it is not by design that it doesn't fail.  It's not > like we decided to allow s-o-b only merge because we found a reason > why it is a good idea to do so. > > So I do not think anybody minds too deeply if somebody came up a > patch to "fix" it.  It's just that nobody tried to create such a > silly merge in real life so far (I do not think you did, either--you > found this out by playing around trying to find corner cases, no?) > Yes and no. I found this out while playing around with the "insert notes in the commit template" patch I sent previously. I wasn't trying to find corner cases, though. -- Kaartic