From: David Turner <novalis@novalis.org>
Date: Sun, 04 Sep 2016 20:40:37 GMT
Subject: Re: [PATCH v2 05/38] refs: create a base class "ref_store" for files_ref_store
Message-ID: <1473021637.6035.27.camel@frank>
In-Reply-To: <39277c75122a374b360057d6e1f6d889a90f6fb4.1473003902.git.mhagger@alum.mit.edu>

On Sun, 2016-09-04 at 18:08 +0200, Michael Haggerty wrote:

> +/* A linked list of ref_stores for submodules: */
> +static struct ref_store *submodule_ref_stores;

I don't like the per-submodule stores being in a linked list, which
requires a linear search.  Stefan has, I think, been doing a bunch of
work to scale git to support on the order of thousands of submodules,
which this potentially breaks.  What about a hashmap?