From: Dennis Kaarsemaker <dennis@kaarsemaker.net>
Date: Mon, 29 Aug 2016 09:47:40 GMT
Subject: Re: [PATCH 15/22] sequencer: introduce a helper to read files written by scripts
Message-ID: <1472464060.4265.27.camel@kaarsemaker.net>
In-Reply-To: <c0c7caa40a452ed9328c21302e4399562d40ec12.1472457609.git.johannes.schindelin@gmx.de>

On ma, 2016-08-29 at 10:06 +0200, Johannes Schindelin wrote:
> +       if (strbuf_read_file(buf, path, 0) < 0) {
> +               warning_errno("could not read '%s'", path);
> +               return 0;
> +       }
> +
> +       if (buf->len > orig_len && buf->buf[buf->len - 1] == '\n') {
> +               if (--buf->len > orig_len && buf->buf[buf->len - 1]
> == '\r')
> +                       --buf->len;
> +               buf->buf[buf->len] = '\0';
> +       }

Why not use open + strbuf_getline instead of hand-rolling a newline
eradicator?

D.