From: Dennis Kaarsemaker Date: Mon, 29 Aug 2016 09:19:20 GMT Subject: Re: [PATCH 01/22] sequencer: use static initializers for replay_opts Message-ID: <1472462360.4265.21.camel@kaarsemaker.net> In-Reply-To: <66d69469a64bd80d3bf2b99a250ae04a649d94d1.1472457609.git.johannes.schindelin@gmx.de> On ma, 2016-08-29 at 10:03 +0200, Johannes Schindelin wrote: > +#define REPLAY_OPTS_INIT { -1, -1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, NULL, NULL, NULL, 0, 0, NULL } This looked off to me, as it replaces memset(..., 0, ...) so is not 100% equivalent. But the changed functions both set opts.action and call parse_args which sets opts.subcommand. D.