From: Vasco Almeida Date: Wed, 27 Jul 2016 10:53:39 GMT Subject: Re: [PATCH v3] i18n: notes: mark comment for translation Message-ID: <1469616819.1858.25.camel@sapo.pt> In-Reply-To: A Ter, 26-07-2016 às 09:57 -0700, Junio C Hamano escreveu: > Vasco Almeida writes: > > > > > + strbuf_add_commented_lines(&buf, "\n", > > strlen("\n")); > > + strbuf_add_commented_lines(&buf, _(note_template), > > strlen(_(note_template))); > > + strbuf_add_commented_lines(&buf, "\n", > > strlen("\n")); > > Hmm, do we really need to make three separate calls? This patch does (1) # # Write/edit the notes for the following object: # The original source does (2) # # Write/edit the notes for the following object: How do we want, (1) or (2) ?