From: David Turner <novalis@novalis.org>
Date: Fri, 10 Jun 2016 19:01:19 GMT
Subject: Re: [PATCH v2 5/6] lock_ref_for_update(): make error handling more uniform
Message-ID: <1465585279.8278.2.camel@frank>
In-Reply-To: <6cc13da6767c5fd9dbf1b372634adf7c3a353464.1465544913.git.mhagger@alum.mit.edu>

On Fri, 2016-06-10 at 10:14 +0200, Michael Haggerty wrote:

>  /*
> + * Check whether the REF_HAVE_OLD and old_oid values stored in update
> + * are consistent with the result read for the reference. error is
> + * true iff there was an error reading the reference; otherwise, oid

"error" is not a thing here?