From: David Turner <dturner@twopensource.com>
Date: Wed, 01 Jun 2016 00:12:34 GMT
Subject: Re: [PATCH 12/13] dir_iterator: new API for iterating over a directory tree
Message-ID: <1464739954.3988.6.camel@twopensource.com>
In-Reply-To: <e99655e5d919852479d223caec42e5bb294b4a2c.1464537050.git.mhagger@alum.mit.edu>

On Mon, 2016-05-30 at 09:55 +0200, Michael Haggerty wrote:
> +struct dir_iterator_level {
> +	int initialized;
> +
> +	DIR *dir;
> +
> +	/*
> +	 * The length of the directory part of refname at this level


"refname"? Isn't this was for directories?

> +			if (lstat(iter->base.path.buf, &iter
->base.st) < 0)
> +				continue; /* silently skip */

Should we warn on non-ENOENT errors here?

> +/*
> + * End the iteration before it has been exhausted. Free the
> reference

s/reference/directory/