From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date: Fri, 19 Aug 2016 08:39:11 GMT
Subject: Re: [PATCH 1/2] help: introduce option --command-only
Message-ID: <1462477081.1237058.1471595951145.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <20160818185719.4909-2-ralf.thielow@gmail.com>

Hi Ralf,

Ralf Thielow <ralf.thielow@gmail.com> writes:
> [...]
> +test_expect_success "works for commands and guides by default" "
> +        git help status &&
> +        git help revisions
> +"
> +
> +test_expect_success "--command-only does not work for guides" "
> +        git help --command-only status &&
> +        cat <<-EOF >expected &&
> +                git: 'revisions' is not a git command. See 'git --help'.
> +        EOF
> +        (git help --command-only revisions 2>actual || true) &&

I think you want to use
  `test_must_fail git help --command-only revisions 2>actual`
here to make sure that the command does fail.

Thanks,
Rémi