From: Mike Hommey Date: Tue, 03 May 2016 08:50:51 GMT Subject: [PATCH v4 10/11] connect: actively reject git:// urls with a user part Message-ID: <1462265452-32360-11-git-send-email-mh@glandium.org> In-Reply-To: <1462265452-32360-1-git-send-email-mh@glandium.org> Currently, urls of the for git://user@host don't work because user@host is not resolving at the DNS level, but we shouldn't be relying on it being an invalid host name, and actively reject it for containing a username in the first place. Signed-off-by: Mike Hommey --- connect.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/connect.c b/connect.c index 0cec822..215d6d9 100644 --- a/connect.c +++ b/connect.c @@ -716,6 +716,9 @@ struct child_process *git_connect(int fd[2], const char *url, */ struct strbuf target_host = STRBUF_INIT; char *override_vhost = getenv("GIT_OVERRIDE_VIRTUAL_HOST"); + if (user) + die("user@host is not allowed in git:// urls"); + if (override_vhost) strbuf_addstr(&target_host, override_vhost); else { -- 2.8.1.16.gaa70619.dirty