From: David Turner Date: Fri, 29 Apr 2016 01:14:34 GMT Subject: Re: [PATCH 00/29] Yet more preparation for reference backends Message-ID: <1461892474.4123.27.camel@twopensource.com> In-Reply-To: On Wed, 2016-04-27 at 18:57 +0200, Michael Haggerty wrote: > This started as a modest attempt to move the last couple of patches > mentioned here [1] to before the vtable patches. I wanted to do that > because having real changes mixed with the vtable refactoring was > making rebasing and stuff awkward. > > But then it snowballed. A lot of what's new is pretty trivial (though > in some cases fixes minor bugs). But a few of the later patches are > pretty major. Apart from the comments on one patch that I sent, this looks good to me. I'm a bit worried about the impact on lmdb (which doesn't do "locking" the same way), but I think it will probably work out. Since Michael has been rebasing the pluggable-refs-backend code on top of this, he's probably got a good sense that it doesn't do too much violence to the plugin infrastructure. >