From: David Turner <dturner@twopensource.com>
Date: Wed, 20 Apr 2016 19:50:40 GMT
Subject: Re: [PATCH v5 10/15] update-index: enable/disable watchman support
Message-ID: <1461181840.5540.171.camel@twopensource.com>
In-Reply-To: <CACsJy8D34SKcA0dsG0ZrsOZiOFLwgEuG-TJ914t4qFV1xZGnew@mail.gmail.com>

On Wed, 2016-04-20 at 06:45 +0700, Duy Nguyen wrote:
> On Wed, Apr 20, 2016 at 6:28 AM, David Turner <
> dturner@twopensource.com> wrote:
> > +       if (use_watchman > 0) {
> > +               the_index.last_update    = xstrdup("");
> > +               the_index.cache_changed |= WATCHMAN_CHANGED;
> > +       } else if (!use_watchman) {
> > +               the_index.last_update    = NULL;
> > +               the_index.cache_changed |= WATCHMAN_CHANGED;
> > +       }
> > +
> 
> We probably should warn people if index-helper is not built with
> watchman support, which makes this knob completely useless. If
> watchman fails to start, that's a separate problem..

Will warn.