From: David Turner Date: Mon, 11 Apr 2016 21:29:22 GMT Subject: Re: [PATCH 0/3] index-helper: fix UNIX_PATH_MAX redefinition error on cygwin Message-ID: <1460410162.5540.20.camel@twopensource.com> In-Reply-To: <20160411133343.GA7492@sigill.intra.peff.net> On Mon, 2016-04-11 at 09:33 -0400, Jeff King wrote: > On Sun, Apr 10, 2016 at 11:57:31PM +0100, Ramsay Jones wrote: > > > So, the approach taken by patch #1 is to forget about UNIX_PATH_MAX > > and > > simply use sizeof(address.sun_path) instead! > > That's what the existing code in unix-socket.c does. Which makes me > wonder why the index-helper code is not simply calling that. Because I didn't notice it at the time. Duy pointed it out on another comment on this series; I'll fix it.