From: Stefan Beller Date: Thu, 31 Mar 2016 18:04:04 GMT Subject: [PATCHv3 2/4] abbrev_sha1_in_line: don't leak memory Message-ID: <1459447446-32260-3-git-send-email-sbeller@google.com> In-Reply-To: <1459447446-32260-1-git-send-email-sbeller@google.com> `split` is of type `struct strbuf **`, and currently we are leaking split itself as well as each element in split[i]. We have a dedicated free function for `struct strbuf **`, which takes care of freeing all related memory. Helped-by: Eric Sunshine Signed-off-by: Stefan Beller --- Notes: Feel free to drop this patch and use the the proposal, which drops `**split` entirely http://thread.gmane.org/gmane.comp.version-control.git/290232/focus=290318 wt-status.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/wt-status.c b/wt-status.c index ef74864..1ea2ebe 100644 --- a/wt-status.c +++ b/wt-status.c @@ -1063,9 +1063,7 @@ static void abbrev_sha1_in_line(struct strbuf *line) strbuf_addf(line, "%s", split[i]->buf); } } - for (i = 0; split[i]; i++) - strbuf_release(split[i]); - + strbuf_list_free(split); } static void read_rebase_todolist(const char *fname, struct string_list *lines) -- 2.5.0.264.g4004fdc.dirty