From: Stefan Beller Date: Thu, 31 Mar 2016 00:17:35 GMT Subject: [PATCH 2/4] submodule--helper clone: simplify path check Message-ID: <1459383457-6848-3-git-send-email-sbeller@google.com> In-Reply-To: <1459383457-6848-1-git-send-email-sbeller@google.com> The calling shell code makes sure that `path` is non null and non empty. (side note: it cannot be null as just three lines before it is passed to safe_create_leading_directories_const which would crash as you feed it null). Signed-off-by: Stefan Beller --- builtin/submodule--helper.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index f4c3eff..88002ca 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -215,10 +215,7 @@ static int module_clone(int argc, const char **argv, const char *prefix) if (safe_create_leading_directories_const(path) < 0) die(_("could not create directory '%s'"), path); - if (path && *path) - strbuf_addf(&sb, "%s/.git", path); - else - strbuf_addstr(&sb, ".git"); + strbuf_addf(&sb, "%s/.git", path); if (safe_create_leading_directories_const(sb.buf) < 0) die(_("could not create leading directories of '%s'"), sb.buf); -- 2.5.0.264.g4004fdc.dirty