From: David Turner <dturner@twopensource.com>
Date: Thu, 25 Feb 2016 20:09:20 GMT
Subject: Re: [PATCH] refs: mark a file-local symbol as static
Message-ID: <1456430960.18017.49.camel@twopensource.com>
In-Reply-To: <56CF55ED.9040906@ramsayjones.plus.com>

On Thu, 2016-02-25 at 19:28 +0000, Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi David,
> 
> No, you are not having flashbacks - you forgot to make the
> register_ref_storage_backend() function static. ;-)

Oops!  Must have lost that in all of the rebasing!  Will fix, thanks.

> BTW, I still have two symbols showing as exported but not used,
> namely:
> 
>     $ diff nsc psc1
>     ...
>     32a35,36
>     > refs.o	- resolve_ref_unsafe_submodule
>     > refs/files-backend.o	- do_for_each_per_worktree_ref
>     $ 
> 
> Both of these symbols are used by the lmdb backend, so I'm assuming
> that
> they are part of the 'refs API' and will (may?) be used by other
> alternate
> reference backends. Is that the case?

Yes.