From: Stefan Beller Date: Thu, 25 Feb 2016 01:42:02 GMT Subject: [PATCH 4/7] run_processes_parallel: correctly terminate callbacks with an LF Message-ID: <1456364525-21190-5-git-send-email-sbeller@google.com> In-Reply-To: <1456364525-21190-1-git-send-email-sbeller@google.com> As the strbufs passed around collect all output to the user, and there is no post processing involved we need to care about the line ending ourselves. Signed-off-by: Stefan Beller --- run-command.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/run-command.c b/run-command.c index 20489c8..8e60812 100644 --- a/run-command.c +++ b/run-command.c @@ -912,6 +912,7 @@ int default_start_failure(struct child_process *cp, strbuf_addstr(out, "Starting a child failed:"); for (i = 0; cp->argv[i]; i++) strbuf_addf(out, " %s", cp->argv[i]); + strbuf_addch(out, '\n'); return 0; } @@ -930,6 +931,7 @@ int default_task_finished(int result, strbuf_addf(out, "A child failed with return code %d:", result); for (i = 0; cp->argv[i]; i++) strbuf_addf(out, " %s", cp->argv[i]); + strbuf_addch(out, '\n'); return 0; } -- 2.7.2.335.g3f96d05