From: David Turner <dturner@twopensource.com>
Date: Fri, 12 Feb 2016 01:09:03 GMT
Subject: Re: [PATCH v4 02/21] refs: add methods for misc ref operations
Message-ID: <1455239343.29013.19.camel@twopensource.com>
In-Reply-To: <56BC3C08.2080003@alum.mit.edu>

On Thu, 2016-02-11 at 08:45 +0100, Michael Haggerty wrote:
> On 02/05/2016 08:44 PM, David Turner wrote:
> > From: Ronnie Sahlberg <sahlberg@google.com>
> > 
> > Add ref backend methods for:
> > resolve_ref_unsafe, verify_refname_available, pack_refs, peel_ref,
> > create_symref, resolve_gitlink_ref.
> > 
> > Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
> > Signed-off-by: David Turner <dturner@twopensource.com>
> > ---
> >  builtin/init-db.c    |  1 +
> >  refs.c               | 36 ++++++++++++++++++++++++++++++++++++
> >  refs/files-backend.c | 33 +++++++++++++++++++++++----------
> >  refs/refs-internal.h | 23 +++++++++++++++++++++++
> >  4 files changed, 83 insertions(+), 10 deletions(-)
> > 
> > diff --git a/builtin/init-db.c b/builtin/init-db.c
> > index 07229d6..26e1cc3 100644
> > --- a/builtin/init-db.c
> > +++ b/builtin/init-db.c
> > @@ -8,6 +8,7 @@
> >  #include "builtin.h"
> >  #include "exec_cmd.h"
> >  #include "parse-options.h"
> > +#include "refs.h"
> 
> You can't see it in this diff's context, but there is already an
> '#include "refs.h"' in this file.

Fixed this.

I think that's all of your comments so far, but I'm going to wait for
your second batch to reroll, to avoid unnecessary churn.