From: David Turner <dturner@twopensource.com>
Date: Thu, 11 Feb 2016 21:21:22 GMT
Subject: Re: [PATCH v4 20/21] refs: add LMDB refs storage backend
Message-ID: <1455225682.29013.12.camel@twopensource.com>
In-Reply-To: <56BC4AE4.6060708@alum.mit.edu>

On Thu, 2016-02-11 at 09:48 +0100, Michael Haggerty wrote:
> On 02/05/2016 08:44 PM, David Turner wrote:
> > Add a database backend for refs using LMDB.  This backend runs git
> > for-each-ref about 30% faster than the files backend with fully
> > -packed
> > refs on a repo with ~120k refs.  It's also about 4x faster than
> > using
> > fully-unpacked refs.  In addition, and perhaps more importantly, it
> > avoids case-conflict issues on OS X.
> 
> When I compile this using gcc with -Werror=pointer-arith, I get the
> following errors:
> 
> > refs/lmdb-backend.c: In function ‘rename_reflog_ent’:
> > refs/lmdb-backend.c:1068:39: error: pointer of type ‘void *’ used
> > in arithmetic [-Werror=pointer-arith]
> >   strbuf_add(&new_key_buf, key.mv_data + key.mv_size - 8, 8);
> >                                        ^
> > refs/lmdb-backend.c:1068:53: error: pointer of type ‘void *’ used
> > in arithmetic [-Werror=pointer-arith]
> >   strbuf_add(&new_key_buf, key.mv_data + key.mv_size - 8, 8);

Fixed, thanks.