From: Elia Pinto Date: Tue, 12 Jan 2016 10:45:16 GMT Subject: [PATCH 08/10] t9110-git-svn-use-svm-props.sh: use the $( ... ) construct for command substitution Message-ID: <1452595518-38149-9-git-send-email-gitter.spiros@gmail.com> In-Reply-To: <1452595518-38149-1-git-send-email-gitter.spiros@gmail.com> The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t9110-git-svn-use-svm-props.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t9110-git-svn-use-svm-props.sh b/t/t9110-git-svn-use-svm-props.sh index a06e4c5..29fbdfd 100755 --- a/t/t9110-git-svn-use-svm-props.sh +++ b/t/t9110-git-svn-use-svm-props.sh @@ -51,7 +51,7 @@ test_expect_success 'verify metadata for /dir' " test_expect_success 'find commit based on SVN revision number' " git svn find-rev r12 | - grep `git rev-parse HEAD` + grep $(git rev-parse HEAD) " test_expect_success 'empty rebase' " -- 2.5.0