From: Elia Pinto Date: Fri, 08 Jan 2016 11:06:19 GMT Subject: [PATCH 01/10] t/t7103-reset-bare.sh: use the $( ... ) construct for command substitution Message-ID: <1452251188-12939-2-git-send-email-gitter.spiros@gmail.com> In-Reply-To: <1452251188-12939-1-git-send-email-gitter.spiros@gmail.com> The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t7103-reset-bare.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t7103-reset-bare.sh b/t/t7103-reset-bare.sh index 1eef93c..afe36a5 100755 --- a/t/t7103-reset-bare.sh +++ b/t/t7103-reset-bare.sh @@ -63,7 +63,7 @@ test_expect_success '"mixed" reset is not allowed in bare' ' test_expect_success '"soft" reset is allowed in bare' ' git reset --soft HEAD^ && - test "`git show --pretty=format:%s | head -n 1`" = "one" + test "$(git show --pretty=format:%s | head -n 1)" = "one" ' test_done -- 2.3.3.GIT