From: Elia Pinto Date: Mon, 04 Jan 2016 09:10:43 GMT Subject: [PATCH 02/10] t/t5530-upload-pack-error.sh: use the $( ... ) construct for command substitution Message-ID: <1451898651-16468-3-git-send-email-gitter.spiros@gmail.com> In-Reply-To: <1451898651-16468-1-git-send-email-gitter.spiros@gmail.com> The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t5530-upload-pack-error.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5530-upload-pack-error.sh b/t/t5530-upload-pack-error.sh index 3932e79..4f6e32b 100755 --- a/t/t5530-upload-pack-error.sh +++ b/t/t5530-upload-pack-error.sh @@ -4,7 +4,7 @@ test_description='errors in upload-pack' . ./test-lib.sh -D=`pwd` +D=$(pwd) corrupt_repo () { object_sha1=$(git rev-parse "$1") && -- 2.3.3.GIT