From: Elia Pinto Date: Tue, 22 Dec 2015 15:05:55 GMT Subject: [PATCH 10/10] t/t3100-ls-tree-restrict.sh: use the $( ... ) construct for command substitution Message-ID: <1450796755-15848-11-git-send-email-gitter.spiros@gmail.com> In-Reply-To: <1450796755-15848-1-git-send-email-gitter.spiros@gmail.com> The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t3100-ls-tree-restrict.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t3100-ls-tree-restrict.sh b/t/t3100-ls-tree-restrict.sh index eb73c06..325114f 100755 --- a/t/t3100-ls-tree-restrict.sh +++ b/t/t3100-ls-tree-restrict.sh @@ -28,7 +28,7 @@ test_expect_success \ echo Mi >path2/baz/b && find path? \( -type f -o -type l \) -print | xargs git update-index --add && - tree=`git write-tree` && + tree=$(git write-tree) && echo $tree' test_output () { -- 2.3.3.GIT