From: David Turner <dturner@twopensource.com>
Date: Wed, 04 Nov 2015 21:01:24 GMT
Subject: Re: [PATCH v6 25/25] refs: break out ref conflict checks
Message-ID: <1446670884.4131.42.camel@twopensource.com>
In-Reply-To: <3060e6410e8798064ef84cd31645021d1b84fbb9.1446534991.git.mhagger@alum.mit.edu>

On Tue, 2015-11-03 at 08:40 +0100, Michael Haggerty wrote:
> + * extras and skip must be sorted lists of reference names. Either one
> + * can be NULL, signifying the empty list.
> + */

My version had:

"skip can be NULL; extras cannot."

The first thing that function does is:
string_list_find_insert_index(extras, dirname, 0)

And that crashes when extras is null.  So I think my version is correct
here.

Other than that, I've reviewed both the patches themselves and the
overall diff and everything looks good to me.