From: David Turner <dturner@twopensource.com>
Date: Mon, 02 Nov 2015 22:19:36 GMT
Subject: Re: [PATCH v5 18/26] refs: move transaction functions into common code
Message-ID: <1446502776.4131.30.camel@twopensource.com>
In-Reply-To: <5635CA8A.2080505@alum.mit.edu>

On Sun, 2015-11-01 at 09:17 +0100, Michael Haggerty wrote:
> On 10/28/2015 03:14 AM, David Turner wrote:
> > The common ref code will build up a ref transaction.  Backends will
> > then commit it.  So the transaction creation and update functions should
> > be in the common code.  We also need to move the ref structs into
> > the common code so that alternate backends can access them.
> > 
> > Later, we will modify struct ref_update to support alternate backends.
> 
> I would prefer that this and later patches *not* add declarations to the
> public API in refs.h for functions and data that are only meant to be
> used by other reference backends.
> 
> So I'm working on a modified version of your series that declares such
> functions in refs-internal.h [1] instead. I hope to submit it tomorrow.

OK, I will fix up your other two issues and then wait for that series.

> Actually, I have half a mind to move all of the refs-related files to a
> subdirectory, like
> 
>     refs.h
>     refs/refs.c
>     refs/refs-internal.h
>     refs/refs-be-files.c
>     refs/refs-be-lmdb.c       <- still to come
> 
> What would you think of that?

Since we're moving stuff around anyway, we might as well introduce a
little more hierarchy.