From: David Turner <dturner@twopensource.com>
Date: Wed, 21 Oct 2015 19:47:40 GMT
Subject: Re: [PATCH v4 23/26] initdb: move safe_create_dir into common code
Message-ID: <1445456860.8302.15.camel@twopensource.com>
In-Reply-To: <xmqq37x4vwon.fsf@gitster.mtv.corp.google.com>

On Wed, 2015-10-21 at 12:38 -0700, Junio C Hamano wrote:
> David Turner <dturner@twopensource.com> writes:
> 
> > In a moment, we'll create initdb functions for ref backends, and code
> > from initdb that calls this function needs to move into the files
> > backend.  So this function needs to be public.
> 
> OK, but unlike the static function, being in public interface part
> can invite mistakes of using this for things outside $GIT_DIR [*1*].
> Let's have "Never use this for working tree directories" somewhere
> in its docstring.

Will fix in the re-roll, thanks.