From: Junio C Hamano Date: Wed, 14 Oct 2015 20:45:27 GMT Subject: [PATCH v2 01/31] mailinfo: remove a no-op call convert_to_utf8(it, "") Message-ID: <1444855557-2127-2-git-send-email-gitster@pobox.com> In-Reply-To: <1444855557-2127-1-git-send-email-gitster@pobox.com> The called function checks if the second parameter is either a NULL or an empty string at the very beginning and returns without doing anything. Remove the useless call. Signed-off-by: Junio C Hamano --- builtin/mailinfo.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/builtin/mailinfo.c b/builtin/mailinfo.c index 999a525..5a4ed75 100644 --- a/builtin/mailinfo.c +++ b/builtin/mailinfo.c @@ -612,11 +612,6 @@ static void decode_header(struct strbuf *it) { if (decode_header_bq(it)) return; - /* otherwise "it" is a straight copy of the input. - * This can be binary guck but there is no charset specified. - */ - if (metainfo_charset) - convert_to_utf8(it, ""); } static void decode_transfer_encoding(struct strbuf *line) -- 2.6.1-320-g86a1181