From: David Turner Date: Tue, 13 Oct 2015 20:40:17 GMT Subject: Re: [PATCH v3 05/44] refs.c: move update_ref to refs.c Message-ID: <1444768817.7234.17.camel@twopensource.com> In-Reply-To: <561C7D7B.8020807@alum.mit.edu> On Tue, 2015-10-13 at 05:41 +0200, Michael Haggerty wrote: > If its removal was intentional, it deserves a careful explanation (and > should probably be done as a separate commit). If it was an accident, > please consider how this accident arose and try to think about whether > similar accidents might have happened elsewhere in this series. This was an accident. I think it must have happened when I forward-ported Ronnie's changes over my change that introduced that check. Usually, when there were conflicts during this process (indicating that the moved code had changed in the meantime), I did the move by copy-pasting the code (rather than by choosing the old version). Apparently, I missed this one. Will fix. > > [...] > > Michael >