From: Max Kirillov Date: Sun, 13 Sep 2015 22:17:41 GMT Subject: [PATCH v9 1/2] submodule refactor: use strbuf_git_path_submodule() in add_submodule_odb() Message-ID: <1442182662-28834-2-git-send-email-max@max630.net> In-Reply-To: <1442182662-28834-1-git-send-email-max@max630.net> Functions which directly operate submodule's object database do not handle the case when the submodule is linked worktree (which are introduced in c7b3a3d2fe). Instead of fixing the path calculation use already existing strbuf_git_path_submodule() function without changing overall behaviour. Then it will be possible to modify only that function whenever we need to change real location of submodule's repository content. Edited-by: Jeff King Signed-off-by: Max Kirillov --- submodule.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/submodule.c b/submodule.c index 245ed4d..16b7c35 100644 --- a/submodule.c +++ b/submodule.c @@ -124,13 +124,7 @@ static int add_submodule_odb(const char *path) int ret = 0; const char *git_dir; - strbuf_addf(&objects_directory, "%s/.git", path); - git_dir = read_gitfile(objects_directory.buf); - if (git_dir) { - strbuf_reset(&objects_directory); - strbuf_addstr(&objects_directory, git_dir); - } - strbuf_addstr(&objects_directory, "/objects/"); + strbuf_git_path_submodule(&objects_directory, path, "objects/"); if (!is_directory(objects_directory.buf)) { ret = -1; goto done; -- 2.3.4.2801.g3d0809b