From: David Turner <dturner@twopensource.com>
Date: Wed, 26 Aug 2015 22:19:05 GMT
Subject: Re: [PATCH v4 2/4] path: optimize common dir checking
Message-ID: <1440627545.26055.8.camel@twopensource.com>
In-Reply-To: <1440627031.26055.5.camel@twopensource.com>

On Wed, 2015-08-26 at 18:10 -0400, David Turner wrote:
> On Wed, 2015-08-26 at 14:15 -0700, Junio C Hamano wrote:
> > > + * For example, consider the following set of strings:
> > > + * abc
> > > + * def
> > > + * definite
> > > + * definition
> > > + *
> > > + * The trie would look look like:
> > > + * root: len = 0, value = (something), children a and d non-NULL.
> > 
> > "value = NULL", as there is no empty string registered in the trie?
> 
> Indeed.
> 
> > > + *    a: len = 2, contents = bc
> > 
> > "value = NULL" here, too (just showing I am following along, not
> > just skimming)?
> 
> Yep.

No, wait. value should be non-NULL, since abc is in the string set.