From: Chris Jones Date: Sat, 11 Jul 2015 02:04:00 GMT Subject: Re: [PATCH] git-filter-branch.sh: clarify an error message Message-ID: <1436580240.2553376.320852705.0F1D7187@webmail.messagingengine.com> In-Reply-To: How does "You did not provide a valid range of commits. At least one tip in your range must be a ref." sound? -- Chris http://christopherjones.us/ On Sun, Jul 5, 2015, at 10:41 AM, Johannes Schindelin wrote: > Hi, > > On 2015-07-05 15:07, Jeff King wrote: > > On Sat, Jul 04, 2015 at 07:39:04PM -0400, Chris Jones wrote: > > > >> Make git filter-branch output a useful error message when a single > >> commit is given instead of a range. Currently, when given a command > >> like git filter-branch --msg-filter 'echo "TEST"' -- abc123, it will > >> give the message "Which ref do you want to rewrite?". Instead, what > >> is needed is a range of commits to rewrite. This makes it give an > >> error message that says "You didn't provide a valid range of > >> commits". > > > > Yeah, I agree the current message is a little confusing, and I think > > your message is an improvement. I wonder if we can even go a step > > further, like mentioning that at least one of the positive tips in your > > range must be a ref. > > I agree, and would even further suggest to use the "did not" form instead > of the abbreviated "didn't" one. > > Thanks, > Dscho