From: David Turner Date: Thu, 25 Jun 2015 22:29:25 GMT Subject: Re: [PATCH v2 2/6] cherry-pick: treat CHERRY_PICK_HEAD and REVERT_HEAD as refs Message-ID: <1435271365.7900.16.camel@twopensource.com> In-Reply-To: On Thu, 2015-06-25 at 14:11 -0700, Junio C Hamano wrote: > David Turner writes: > > > Instead of directly writing to and reading from files in > > $GIT_DIR, use ref API to interact with CHERRY_PICK_HEAD > > and REVERT_HEAD. > > > > Signed-off-by: David Turner > > --- > > I may have said this already in the last round, but I cannot shake > off the feeling that this patch is doing two completely unrelated > things at once. > > The change to refs.c that introduced the should_autocreate_reflog() > helper (which is a good idea even without any other changes in this > patch) I'll break that out into a separate patch when I reroll. > and then using that to commit_ref_update() does not have > anything to do with CHERRY_PICK_HEAD/REVERT_HEAD, does it? I had thought that it did, but some testing shows that it does not (or at least does not yet). The original series of patches was assembled out of a long process of making the test suite pass with the alternate ref backend. I expect that as I rewrite that series, I'll either figure out what issues these change solved, or remove them. In this case, I'll split the patch. > * commit_ref_update() gained a new "flags" parameter, but it does > not seem to be used at all. Why? cruft, will remove.