From: David Turner Date: Tue, 23 Jun 2015 21:31:14 GMT Subject: Re: [PATCH 2/2] introduce "preciousObjects" repository extension Message-ID: <1435095074.28466.74.camel@twopensource.com> In-Reply-To: <20150623105411.GB12518@peff.net> On Tue, 2015-06-23 at 06:54 -0400, Jeff King wrote: > + mkconfig 1 preciousObjects >.git/config && nit: I think it's better to use git config rather than manually writing config files. git config is more future-proof if we up switching config backends; it's also more composable with other configs (making this test easier to copy and manipulate), and more explicit. Other than that it looks good to me.