From: Remi Lespinet Date: Wed, 17 Jun 2015 14:30:33 GMT Subject: [PATCH/RFC v4 08/10] send-email: consider quote as delimiter instead of character Message-ID: <1434551433-24614-1-git-send-email-remi.lespinet@ensimag.grenoble-inp.fr> In-Reply-To: <1434550720-24130-1-git-send-email-remi.lespinet@ensimag.grenoble-inp.fr> Do not consider quote inside a recipient name as character when they are not escaped. This interprets: "Jane" "Doe" as: "Jane Doe" instead of: "Jane\" \"Doe" Signed-off-by: Remi Lespinet --- I don't know if it's an argument for this change, but rfc2822 says: Semantically, neither the optional CFWS outside of the quote characters nor the quote characters themselves are part of the quoted-string... git-send-email.perl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/git-send-email.perl b/git-send-email.perl index a1f6c18..8594ab9 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -1078,15 +1078,17 @@ sub sanitize_address { return $recipient; } + # remove non-escaped quotes + $recipient_name =~ s/(^|[^\\])"/$1/g; + # rfc2047 is needed if a non-ascii char is included if ($recipient_name =~ /[^[:ascii:]]/) { - $recipient_name =~ s/^"(.*)"$/$1/; $recipient_name = quote_rfc2047($recipient_name); } # double quotes are needed if specials or CTLs are included elsif ($recipient_name =~ /[][()<>@,;:\\".\000-\037\177]/) { - $recipient_name =~ s/(["\\\r])/\\$1/g; + $recipient_name =~ s/([\\\r])/\\$1/g; $recipient_name = qq["$recipient_name"]; } -- 1.9.1