From: David Turner <dturner@twopensource.com>
Date: Sat, 09 May 2015 20:02:46 GMT
Subject: Re: [PATCH v2 2/3] sha1_name: get_sha1_with_context learns to follow symlinks
Message-ID: <1431201766.24139.1.camel@ubuntu>
In-Reply-To: <xmqq7fsiifcz.fsf@gitster.dls.corp.google.com>

On Fri, 2015-05-08 at 20:45 -0700, Junio C Hamano wrote:
> dturner@twopensource.com writes:
> 
> > From: David Turner <dturner@twitter.com>
> >
> > Wire up get_sha1_with_context to call get_tree_entry_follow_symlinks
> > when GET_SHA1_FOLLOW_SYMLINKS is passed in flags. G_S_FOLLOW_SYMLINKS
> > is incompatible with G_S_ONLY_TO_DIE because the diagnosis that
> > ONLY_TO_DIE triggers does not consider symlinks.
> 
> Is "does not consider" something fundamental, or it just happens to
> be that way right now?

It just happens to be that way right now.  It would require work
approximately equivalent to this patch series to fix.