From: SZEDER Gábor Date: Fri, 01 May 2015 15:48:56 GMT Subject: [PATCH] completion: remove redundant __git_compute_all_commands() call Message-ID: <1430495336-8456-1-git-send-email-szeder@ira.uka.de> During lazy-initialization of the lists of all commands and porcelain commands the function __git_compute_all_commands() is called twice. The relevant part of the call sequence looks like this: __git_compute_porcelain_commands() __git_compute_all_commands() __git_list_all_commands() __git_list_porcelain_commands() __git_compute_all_commands() Either one of the two calls could be removed and the initialization of both command lists would still work as a whole, but let's remove the call from __git_compute_porcelain_commands(), because this way __git_list_porcelain_commands() will keep working in itself. Signed-off-by: SZEDER Gábor --- contrib/completion/git-completion.bash | 1 - 1 file changed, 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 5944c82..8b0d2b4 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -735,7 +735,6 @@ __git_list_porcelain_commands () __git_porcelain_commands= __git_compute_porcelain_commands () { - __git_compute_all_commands test -n "$__git_porcelain_commands" || __git_porcelain_commands=$(__git_list_porcelain_commands) } -- 1.9.5.msysgit.0