From: Patrick Steinhardt Date: Thu, 09 Apr 2015 13:41:56 GMT Subject: [PATCH] grep: correctly initialize help-all option Message-ID: <1428586916-22679-1-git-send-email-ps@pks.im> The "help-all" option is being initialized with a wrong value. While being semantically wrong this can also cause a gcc segmentation fault on ARMv7 hardfloat platforms with a hardened toolchain. Fix this by initializing with the correct value. --- builtin/grep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/grep.c b/builtin/grep.c index abc4400..c0bf005 100644 --- a/builtin/grep.c +++ b/builtin/grep.c @@ -738,7 +738,7 @@ int cmd_grep(int argc, const char **argv, const char *prefix) PARSE_OPT_OPTARG, NULL, (intptr_t)default_pager }, OPT_BOOL(0, "ext-grep", &external_grep_allowed__ignored, N_("allow calling of grep(1) (ignored by this build)")), - { OPTION_CALLBACK, 0, "help-all", &options, NULL, N_("show usage"), + { OPTION_CALLBACK, 0, "help-all", &opt, NULL, N_("show usage"), PARSE_OPT_HIDDEN | PARSE_OPT_NOARG, help_callback }, OPT_END() }; -- 2.3.5