From: Stefan Beller Date: Fri, 27 Mar 2015 22:09:10 GMT Subject: [PATCH 6/6] WIP/RFC/entry.c: fix a memleak Message-ID: <1427494150-8085-11-git-send-email-sbeller@google.com> In-Reply-To: <1427494150-8085-1-git-send-email-sbeller@google.com> I observe that filter is going out of scope, but the implementation proposed in this patch produces just a crash instead of any helpful fix. Signed-off-by: Stefan Beller --- entry.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/entry.c b/entry.c index 1eda8e9..5383001 100644 --- a/entry.c +++ b/entry.c @@ -152,8 +152,10 @@ static int write_entry(struct cache_entry *ce, if (filter && !streaming_write_entry(ce, path, filter, state, to_tempfile, - &fstat_done, &st)) + &fstat_done, &st)) { + free_stream_filter(filter); goto finish; + } } switch (ce_mode_s_ifmt) { -- 2.3.0.81.gc37f363