From: Michael Haggerty Date: Thu, 12 Feb 2015 11:12:19 GMT Subject: [PATCH v2 08/12] ref_transaction_create(): check that new_sha1 is valid Message-ID: <1423739543-1025-9-git-send-email-mhagger@alum.mit.edu> In-Reply-To: <1423739543-1025-1-git-send-email-mhagger@alum.mit.edu> Creating a reference requires a new_sha1 that is not NULL and not null_sha1. Signed-off-by: Michael Haggerty Reviewed-by: Stefan Beller --- refs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/refs.c b/refs.c index ddb8bca..3f78fac 100644 --- a/refs.c +++ b/refs.c @@ -3690,6 +3690,8 @@ int ref_transaction_create(struct ref_transaction *transaction, int flags, const char *msg, struct strbuf *err) { + if (!new_sha1 || is_null_sha1(new_sha1)) + die("BUG: create called without valid new_sha1"); return ref_transaction_update(transaction, refname, new_sha1, null_sha1, flags, msg, err); } -- 2.1.4