From: Michael Haggerty Date: Mon, 09 Feb 2015 09:12:37 GMT Subject: [PATCH 1/8] write_ref_sha1(): remove check for lock == NULL Message-ID: <1423473164-6011-2-git-send-email-mhagger@alum.mit.edu> In-Reply-To: <1423473164-6011-1-git-send-email-mhagger@alum.mit.edu> None of the callers pass NULL to this function, and there doesn't seem to be any usefulness to allowing them to do so. Signed-off-by: Michael Haggerty --- refs.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/refs.c b/refs.c index c5fa709..d1130e2 100644 --- a/refs.c +++ b/refs.c @@ -3080,10 +3080,6 @@ static int write_ref_sha1(struct ref_lock *lock, static char term = '\n'; struct object *o; - if (!lock) { - errno = EINVAL; - return -1; - } if (!lock->force_write && !hashcmp(lock->old_sha1, sha1)) { unlock_ref(lock); return 0; -- 2.1.4