From: Michael Haggerty Date: Wed, 01 Oct 2014 10:28:26 GMT Subject: [PATCH v7 22/38] git_config_set_multivar_in_file(): avoid call to rollback_lock_file() Message-ID: <1412159322-2622-23-git-send-email-mhagger@alum.mit.edu> In-Reply-To: <1412159322-2622-1-git-send-email-mhagger@alum.mit.edu> After commit_lock_file() is called, then the lock_file object is necessarily either committed or rolled back. So there is no need to call rollback_lock_file() again in either of these cases. Signed-off-by: Michael Haggerty --- config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/config.c b/config.c index a677eb6..123ed29 100644 --- a/config.c +++ b/config.c @@ -2083,6 +2083,7 @@ int git_config_set_multivar_in_file(const char *config_filename, if (commit_lock_file(lock) < 0) { error("could not commit config file %s", config_filename); ret = CONFIG_NO_WRITE; + lock = NULL; goto out_free; } -- 2.1.0