From: Michael Haggerty Date: Fri, 26 Sep 2014 10:08:05 GMT Subject: [PATCH v6 05/39] rollback_lock_file(): exit early if lock is not active Message-ID: <1411726119-31598-6-git-send-email-mhagger@alum.mit.edu> In-Reply-To: <1411726119-31598-1-git-send-email-mhagger@alum.mit.edu> Eliminate a layer of nesting. Signed-off-by: Michael Haggerty Reviewed-by: Ronnie Sahlberg Reviewed-by: Jonathan Nieder --- lockfile.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lockfile.c b/lockfile.c index 5330d6a..e55149a 100644 --- a/lockfile.c +++ b/lockfile.c @@ -276,10 +276,11 @@ int hold_locked_index(struct lock_file *lk, int die_on_error) void rollback_lock_file(struct lock_file *lk) { - if (lk->filename[0]) { - if (lk->fd >= 0) - close(lk->fd); - unlink_or_warn(lk->filename); - lk->filename[0] = 0; - } + if (!lk->filename[0]) + return; + + if (lk->fd >= 0) + close(lk->fd); + unlink_or_warn(lk->filename); + lk->filename[0] = 0; } -- 2.1.0