From: Michael Haggerty Date: Sat, 06 Sep 2014 07:50:35 GMT Subject: [PATCH v4 21/32] dump_marks(): remove a redundant call to rollback_lock_file() Message-ID: <1409989846-22401-22-git-send-email-mhagger@alum.mit.edu> In-Reply-To: <1409989846-22401-1-git-send-email-mhagger@alum.mit.edu> When commit_lock_file() fails, it now always calls rollback_lock_file() internally, so there is no need to call that function here. Signed-off-by: Michael Haggerty --- fast-import.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fast-import.c b/fast-import.c index d73f58c..55cb47a 100644 --- a/fast-import.c +++ b/fast-import.c @@ -1803,10 +1803,8 @@ static void dump_marks(void) } if (commit_lock_file(&mark_lock)) { - int saved_errno = errno; - rollback_lock_file(&mark_lock); failure |= error("Unable to commit marks file %s: %s", - export_marks_file, strerror(saved_errno)); + export_marks_file, strerror(errno)); return; } } -- 2.1.0