From: Keller, Jacob E Date: Fri, 29 Aug 2014 15:23:31 GMT Subject: Re: [PATCH 8/9] autoconf: Check for timer_settime Message-ID: <1409325810.18778.6.camel@jekeller-desk1.amr.corp.intel.com> In-Reply-To: <1409187862-21257-9-git-send-email-sortie@maxsi.org> On Thu, 2014-08-28 at 03:04 +0200, Jonas 'Sortie' Termansen wrote: > This function will be used in a following commit. > > The timer_settime function is provided in librt on some systems. We > already use this library sometimes to get clock_gettime, so rework the > logic so we don't link with it twice. > > This function was not previously used by git. This can cause trouble for > people on systems without timer_settime if they only rely on > config.mak.uname. They will need to set NO_TIMER_SETTIME manually. > > Add proper replacement function macros for setitimer and timer_settime > that evaluates the arguments and fails with ENOSYS to simulate stub > implementations. This will be useful in a following commit. > > Signed-off-by: Jonas 'Sortie' Termansen > > --- > > This patch can be improved by finding out which systems doesn't have > timer_settime and adding entries for them to config.mak.uname. > > Makefile | 21 +++++++++++++++++++++ > config.mak.uname | 3 +++ > configure.ac | 8 ++++++++ > git-compat-util.h | 8 +++++++- > 4 files changed, 39 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 66329e4..5609e44 100644 > --- a/Makefile > +++ b/Makefile > @@ -182,16 +182,22 @@ all:: > # > # Define NO_SETITIMER if you don't have setitimer() > # > +# Define NO_TIMER_SETTIME if you don't have timer_settime() > +# > # Define NO_TIMER_T if you don't have timer_t. > +# This also implies NO_SETITIMER Don't you mean it implies NO_TIMER_SETTIME? It seems to me that these were all added for TIMER_SETTIME, and not NO_SETTIMER? Or am I just thoroughly confused? Regards, Jake