From: David Turner <dturner@twopensource.com>
Date: Fri, 22 Aug 2014 00:22:54 GMT
Subject: Re: [PATCH 18/18] signed push: final protocol update
Message-ID: <1408666974.1282.16.camel@leckie>
In-Reply-To: <1408485987-3590-19-git-send-email-gitster@pobox.com>

On Tue, 2014-08-19 at 15:06 -0700, Junio C Hamano wrote:
>  
> +If the receiving end does not support push-cert, the sending end MUST
> +NOT send a push-cert command.
> +
> +When a push-cert command is sent, command-list MUST NOT be sent; the
> +commands recorded in the push certificate is used instead.  The GPG
> +signature lines are detached signature for the contents recorded in

"are a detached signature"

> +the push certificate before the signature block begins and is used

"which is used" (or "and are used")

> +to certify that the commands were given by the pusher which must be

", who must be"

> +the signer.
> +
> +
> +The receive-pack server that advertises this capability is willing
> +to accept a signed push certificate.  A send-pack client MUST NOT
> +send push-cert packet unless the receive-pack server advertises this

"packets" (or "a push-cert packet")

>  
> +static void queue_commands_from_cert(struct command **p,

Uninformative parameter name p.