From: Ronnie Sahlberg Date: Wed, 16 Jul 2014 22:23:11 GMT Subject: [PATCH 11/12] refs.c: make write_ref_sha1 static Message-ID: <1405549392-27306-12-git-send-email-sahlberg@google.com> In-Reply-To: <1405549392-27306-1-git-send-email-sahlberg@google.com> No external users call write_ref_sha1 any more so lets declare it static. Signed-off-by: Ronnie Sahlberg --- refs.c | 10 ++++++++-- refs.h | 3 --- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/refs.c b/refs.c index 69cbca5..6c7a9d2 100644 --- a/refs.c +++ b/refs.c @@ -2643,6 +2643,9 @@ static int rename_tmp_log(const char *newrefname) return 0; } +static int write_ref_sha1(struct ref_lock *lock, const unsigned char *sha1, + const char *logmsg); + int rename_ref(const char *oldrefname, const char *newrefname, const char *logmsg) { unsigned char sha1[20], orig_sha1[20]; @@ -2892,8 +2895,11 @@ static int is_branch(const char *refname) return !strcmp(refname, "HEAD") || starts_with(refname, "refs/heads/"); } -/* This function must return a meaningful errno */ -int write_ref_sha1(struct ref_lock *lock, +/* + * Writes sha1 into the ref specified by the lock. Makes sure that errno + * is sane on error. + */ +static int write_ref_sha1(struct ref_lock *lock, const unsigned char *sha1, const char *logmsg) { static char term = '\n'; diff --git a/refs.h b/refs.h index fc7942c..b0476c1 100644 --- a/refs.h +++ b/refs.h @@ -196,9 +196,6 @@ extern int commit_ref(struct ref_lock *lock); /** Release any lock taken but not written. **/ extern void unlock_ref(struct ref_lock *lock); -/** Writes sha1 into the ref specified by the lock. **/ -extern int write_ref_sha1(struct ref_lock *lock, const unsigned char *sha1, const char *msg); - /* * Setup reflog before using. Set errno to something meaningful on failure. */ -- 2.0.1.527.gc6b782e