From: Keller, Jacob E <jacob.e.keller@intel.com>
Date: Tue, 15 Jul 2014 23:46:14 GMT
Subject: Re: [PATCH v9 4/4] tag: support configuring --sort via .gitconfig
Message-ID: <1405467974.2577.21.camel@jekeller-desk1.amr.corp.intel.com>
In-Reply-To: <20140715234240.GB5572@peff.net>

On Tue, 2014-07-15 at 19:42 -0400, Jeff King wrote:
> On Tue, Jul 15, 2014 at 04:32:59PM -0700, Jacob Keller wrote:
> 
> > +static void error_bad_sort_config(const char *err, va_list params)
> > +{
> > +	vreportf("warning: tag.sort has ", err, params);
> > +}
> 
> This feels a little like an abuse of the "prefix" field of vreportf, but
> as you probably saw in my "for fun" patch, doing it right means
> formatting into a buffer and then reformatting that (which we're
> already doing again in vreportf, but less flexibly). I dunno.
> 
> At any rate, this should be marked for translation, no?
> 
> -Peff

Oh, yes it probably should. It's definitely a little bit abusive of the
prefix field, but that seemed easier.

Thanks,
Jake