From: Keller, Jacob E <jacob.e.keller@intel.com>
Date: Tue, 15 Jul 2014 21:31:09 GMT
Subject: Re: [PATCH 3/3] tag: support configuring --sort via .gitconfig
Message-ID: <1405459868.2577.9.camel@jekeller-desk1.amr.corp.intel.com>
In-Reply-To: <xmqqha2iv3kr.fsf@gitster.dls.corp.google.com>

On Tue, 2014-07-15 at 12:12 -0700, Junio C Hamano wrote:
> "Keller, Jacob E" <jacob.e.keller@intel.com> writes:
> 
> > I am going to re-submit this with an enum-style return. I am also
> > changing how we parse so that we can correctly report whether the sort
> > function or sort atom is incorrect.
> 
> Oh, our mails crossed, I guess.  As long as it will leave the door
> open for later enhancements for more context sensitive error
> diagnosis, I do not particularly mind a solution around enum.

I just sent a v8 of the series. I think I mostly followed Peff's idea of
using a pop_error_routine function, but not as complex as his was. This
overall results in more accurate errors, and doesn't clutter the
original parse_sort_string with too much knowledge about what particular
value is being parsed. Hopefully we can finally converge on a good set
of patches.

Thanks,
Jake