From: Ronnie Sahlberg Date: Mon, 14 Jul 2014 20:58:46 GMT Subject: [PATCH v21 04/19] refs.c: allow passing NULL to ref_transaction_free Message-ID: <1405371541-32121-5-git-send-email-sahlberg@google.com> In-Reply-To: <1405371541-32121-1-git-send-email-sahlberg@google.com> Allow ref_transaction_free(NULL) as a no-op. This makes ref_transaction_free easier to use and more similar to plain 'free'. In particular, it lets us rollback unconditionally as part of cleanup code after setting 'transaction = NULL' if a transaction has been committed or rolled back already. Reviewed-by: Jonathan Nieder Reviewed-by: Michael Haggerty Signed-off-by: Ronnie Sahlberg --- refs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/refs.c b/refs.c index 21ed465..1d6dece 100644 --- a/refs.c +++ b/refs.c @@ -3338,6 +3338,9 @@ void ref_transaction_free(struct ref_transaction *transaction) { int i; + if (!transaction) + return; + for (i = 0; i < transaction->nr; i++) free(transaction->updates[i]); -- 2.0.1.546.gf603308